News:

Welcome to the Desert!  Register, post, and have fun.  Why not introduce yourself in the
Welcome Thread?

Main Menu

New Layout: DISCUSS

Started by kamakaziplumber, June 15, 2011, 03:30:41 PM

Previous topic - Next topic

MagmarFire

Quote from: Shikatache on July 14, 2011, 09:28:50 AM
Maybe it's Firefox 3.

Also, every page tells me there's a stack overflow at line 1322.

I didn't know that PHP used stacks.



Advanceshipping and Rion had better be Chuck Norris approved.

Keaton

I'm using Chrome and it's working fine for me, other than the aforementioned left justify

Vaati

Well, whatever you guys did to make the forum look like it does now, DON'T CHANGE IT!!!  ;)

kamakaziplumber

#33
Well, I can't find a solution to the Stack Overflow/Out of Memory errors because I don't know what's causing them.  I was hoping maybe it was the Flash banner, but even getting rid of that didn't help. It only appears in Internet Explorer as far as I can tell, though, so you might be better off switching to Chrome or Firefox at this point. =/

EDIT:: OR the solution could be the very next thing I search. The error messages should be gone now.
The Fourth! A webcomic about the hopeless case of the game villain.

"Tis music that soothes the savage beast, but the dagger that causes long slumbers."
- Me!

MagmarFire

Out of curiosity, what was causing the error?



Advanceshipping and Rion had better be Chuck Norris approved.

kamakaziplumber

SMF has a setting that resizes avatars using javascript. IE doesn't play well with javascript, so I turned it off.
The Fourth! A webcomic about the hopeless case of the game villain.

"Tis music that soothes the savage beast, but the dagger that causes long slumbers."
- Me!

MagmarFire

Oh, IE... Why am I not surprised? -_-`



Advanceshipping and Rion had better be Chuck Norris approved.

kamakaziplumber

Yes.

Regarding Tach's centering issue: no dice. So much of the site layout around the forum is positioned absolutely, to the pixel, that it would be a major pain to figure out how to get that to center according to your screen. Also, the CSS I was trying to use to center the page would not budge it at all. I'm willing to bet it's because of some of the positioned stuff, but I can't be sure.

tl;dr the site is too weirdly coded in the first place to support it.

HNS I still don't know what to do about your issue because I can't reproduce it.
The Fourth! A webcomic about the hopeless case of the game villain.

"Tis music that soothes the savage beast, but the dagger that causes long slumbers."
- Me!

MagmarFire

#38
Ya think we should try doing a complete restructuring of the site's HTML? It would take a lot of work, to be sure, but I noticed that a bunch of the content is rendered in tables (and a lot of those tables are nested inside more tables!)--another likely culprit behind the idiosyncratic sizing. Using tables for layout also uses up a bit more memory, so for some clients, that could help in terms of speed if we switched to simple <div>s. I also noticed that a significant portion of block-displayed content is rendered inside of an inline element, and a deprecated one, at that.

And I dunno about you, but the numerous usages of absolute positioning for a lot of our content blocks is...well, scary from a maintenance standpoint and a cross-browser standpoint. We could accomplish all the positioning simply by nesting simple block elements inside one another and making sure the ancestors are rendered just right.

Again, it would take a lot of work, but it would make future theming potentially more flexible and less of a headache to navigate.

Please forgive me if this sounds like unwarranted criticism, but structurally, some of the implementation (not necessarily yours, of course) rubs me the wrong way. Of course, it may have been an inherited thing from the time when XHTML practices weren't as widespread as they are today.



Advanceshipping and Rion had better be Chuck Norris approved.

Hi no Seijin

Quote from: kamakaziplumber on July 14, 2011, 06:56:28 PM
HNS I still don't know what to do about your issue because I can't reproduce it.
Well, it's only an issue if I use the default theme, but I'm using the Core Theme (I think I'm the only one).  So, I dunno, just tell people to not use IE; which, hopefully, they're not anyway since it sucks.
Best.  Cane.  EVER!
Secretary of Lolcats; I won the MagmarFire Award for 2/21/08!
Filler.Filler.Filler.Fillah!  Filler.Filler.Filler.Fillah!

kamakaziplumber

HNS, I took the liberty of making a new layout called "TDC New Full." It basically just gets rid of TDC's site layout container, so the layout spans the entire screen but has the same style. There's no reason why you shouldn't be able to use the new layout. It should get rid of the issue, which I'm beginning to doubt is even related to IE in the first place since I can't really reproduce it in my own IE installations/emulations.

Also Tach: using that theme will fix your resolution issue, if you'd like to use it. Up to you.

The default will remain the theme with the site layout in place, but you can change your theme to the Full one through your profile.
The Fourth! A webcomic about the hopeless case of the game villain.

"Tis music that soothes the savage beast, but the dagger that causes long slumbers."
- Me!

Keaton

Thanks, KP!  Works beautifully.

Hi no Seijin

TDC New Full does look much better.  Thanks.
Best.  Cane.  EVER!
Secretary of Lolcats; I won the MagmarFire Award for 2/21/08!
Filler.Filler.Filler.Fillah!  Filler.Filler.Filler.Fillah!

MagmarFire

It works nicely for me, as well. Very good job!

As an improvement suggestion, it would help a little if there were a link to the front page. However, the lack of one is by no means problematic for me, so if you don't get around to it soon, I won't complain.



Advanceshipping and Rion had better be Chuck Norris approved.

Pale Dim

I like this new layout...a lot. In fact, I love it.


3308-7723-6389